feat: Expose cdn settings as params #1204
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we could use the default function of hugo, and use the config parameters if set, or use the original cdns if not. |
|
I'll have a look at how the scripts partial would look if we used defaults. |
|
Sorry for the delay, I just pushed up changes to include defaults inside the templates. |
This moves the configuration of much of the cdn (js/css) into the configuration so they can be more easily maintained. Signed-off-by: Brad Beam <[email protected]>
Signed-off-by: Brad Beam <[email protected]>
I like the idea. This PR does not pull in the latest versions of the resources, however (e.g. it pulls in KaTeX 0.15.1, while latest version is 0.16.2.) Were great if this could be improved. |
|
I wanted to keep the scope of the change as minimal as possible. I think version bumps can be done as followups to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the configuration of much of the cdn (js/css) into the configuration
so they can be more easily maintained.
Signed-off-by: Brad Beam [email protected]